Skip to content

Fix sorting of platforms and boards #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2021
Merged

Fix sorting of platforms and boards #1282

merged 1 commit into from
May 7, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes an existing feature.

  • What is the current behavior?

The core list, core search and board list commands return results sorted in alphabetical order but taking into account capitalized platform names and boards FQBNs.
For example:

$ arduino-cli core search
ID                    Version   Name                                                                    
arduino:avr           1.8.3     Arduino AVR Boards                                                                                    
arduino:sam           1.6.12    Arduino SAM Boards (32-bits ARM Cortex-M3)                                                   
arduino:megaavr       1.8.7     Arduino megaAVR Boards                                                  
arduino:nrf52         1.0.2     Arduino nRF52 Boards
  • What is the new behavior?

Now core list, core search and board list commands return their results sorted in alphabetical order but in a case insensitive way.

This also affects the gRPC interface.

For example:

$ arduino-cli core search
ID                    Version   Name                                                                    
arduino:avr           1.8.3     Arduino AVR Boards                                                      
arduino:megaavr       1.8.7     Arduino megaAVR Boards                                                  
arduino:nrf52         1.0.2     Arduino nRF52 Boards                                                    
arduino:sam           1.6.12    Arduino SAM Boards (32-bits ARM Cortex-M3)

Nope.

  • Other information:

None.

See how to contribute

@silvanocerza silvanocerza requested a review from a team May 7, 2021 15:49
@silvanocerza silvanocerza self-assigned this May 7, 2021
@silvanocerza silvanocerza merged commit 6095a84 into master May 7, 2021
@silvanocerza silvanocerza deleted the scerza/fix-sorting-order branch May 7, 2021 20:58
silvanocerza added a commit that referenced this pull request May 10, 2021
@silvanocerza
Fix sorting of platforms and boards (#1282)
59c2348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos approved these changes

Assignees

@silvanocerza silvanocerza

Labels
type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @umbynos